linux-kernel - Re: [PATCH -next] integrity: Remove set but not used variable 'acl'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be6aaeb1-13ab-50bc-81a6-c461d3748820@huawei.com>
Date:   Thu, 4 Jul 2019 09:23:15 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     David Howells <dhowells@...hat.com>
CC:     James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Kairui Song <kasong@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Mimi Zohar" <zohar@...ux.ibm.com>,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>,
        Eric Biggers <ebiggers@...gle.com>,
        <linux-security-module@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH -next] integrity: Remove set but not used variable 'acl'

On 2019/7/3 21:57, David Howells wrote:
> YueHaibing <yuehaibing@...wei.com> wrote:
> 
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> security/integrity/digsig.c: In function 'integrity_init_keyring':
>> security/integrity/digsig.c:99:18: warning:
>>  variable 'acl' set but not used [-Wunused-but-set-variable]
>>
>> It seems 'acl' is needed in __integrity_init_keyring
> 
> I've folded this fix in, thanks.

Thanks, also I write a wrong patch title.

> 
> David
> 
> .
>