lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 4 Jul 2019 13:49:17 +0200
From:   Geert Uytterhoeven <>
To:     Arnd Bergmann <>
Cc:     Marek Vasut <>,
        Jonathan Cameron <>,
        stable <>,
        Marek Vasut <>,
        Geert Uytterhoeven <>,
        Simon Horman <>,
        Linux-Renesas <>,
        Wolfram Sang <>,
        Hartmut Knaack <>,
        Lars-Peter Clausen <>,
        Peter Meerwald-Stadler <>,
        Rob Herring <>,
        Kuninori Morimoto <>,,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

Hi Arnd,

On Thu, Jul 4, 2019 at 1:38 PM Arnd Bergmann <> wrote:
> gcc-9 complains about a blatant uninitialized variable use that
> all earlier compiler versions missed:
> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Actually gcc-4.1 warned about that one too ;-)

So either I must have missed that warning when it appeared first,
or I must have concluded wrongly that it was a false positive.
Sorry for that...

> Return -EINVAL instead here.
> Cc:
> Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> Signed-off-by: Arnd Bergmann <>

Reviewed-by: Geert Uytterhoeven <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists