lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 4 Jul 2019 14:07:56 +0200
From:   Wolfram Sang <>
To:     Arnd Bergmann <>
Cc:     Marek Vasut <>,
        Jonathan Cameron <>,,
        Marek Vasut <>,
        Geert Uytterhoeven <>,
        Simon Horman <>,,
        Hartmut Knaack <>,
        Lars-Peter Clausen <>,
        Peter Meerwald-Stadler <>,
        Rob Herring <>,
        Kuninori Morimoto <>,,
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
> gcc-9 complains about a blatant uninitialized variable use that
> all earlier compiler versions missed:
> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> Return -EINVAL instead here.
> Cc:
> Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> Signed-off-by: Arnd Bergmann <>

This is correct but missing that the above 'return ret' is broken, too.
ret is initialized but 0 in that case.

And maybe we can use something else than -EINVAL for this case? I am on
the go right now, I will look for a suggestion later.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists