[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdXDN60WWFerok1h05COdNNPZTMDCgKXejmQZMj9B6y5Cw@mail.gmail.com>
Date: Thu, 4 Jul 2019 14:10:22 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Wolfram Sang <wsa@...-dreams.de>
Cc: Arnd Bergmann <arnd@...db.de>, Marek Vasut <marek.vasut@...il.com>,
Jonathan Cameron <jic23@...nel.org>,
stable <stable@...r.kernel.org>,
Marek Vasut <marek.vasut+renesas@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Simon Horman <horms+renesas@...ge.net.au>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>,
Rob Herring <robh@...nel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
linux-iio@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code
Hi Wolfram,
On Thu, Jul 4, 2019 at 2:08 PM Wolfram Sang <wsa@...-dreams.de> wrote:
> On Thu, Jul 04, 2019 at 01:37:47PM +0200, Arnd Bergmann wrote:
> > gcc-9 complains about a blatant uninitialized variable use that
> > all earlier compiler versions missed:
> >
> > drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > Return -EINVAL instead here.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> This is correct but missing that the above 'return ret' is broken, too.
> ret is initialized but 0 in that case.
Nice catch! Oh well, given enough eyeballs, ...
> And maybe we can use something else than -EINVAL for this case? I am on
> the go right now, I will look for a suggestion later.
-EINVAL is correct here (and in the above case, too), IMHO.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists