linux-kernel - Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tvc0lngz.fsf@linux.intel.com>
Date:   Fri, 05 Jul 2019 14:39:24 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Pawel Laszczak <pawell@...ence.com>, devicetree@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        hdegoede@...hat.com, heikki.krogerus@...ux.intel.com,
        robh+dt@...nel.org, rogerq@...com, linux-kernel@...r.kernel.org,
        jbergsagel@...com, nsekhar@...com, nm@...com, sureshp@...ence.com,
        peter.chen@....com, jpawar@...ence.com, kurahul@...ence.com,
        Pawel Laszczak <pawell@...ence.com>
Subject: Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.


Hi,

Pawel Laszczak <pawell@...ence.com> writes:
> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
> index da82606be605..d388a3a5ab7e 100644
> --- a/include/linux/usb/ch9.h
> +++ b/include/linux/usb/ch9.h
> @@ -70,4 +70,29 @@ extern enum usb_device_speed usb_get_maximum_speed(struct device *dev);
>   */
>  extern const char *usb_state_string(enum usb_device_state state);
>  
> +/**
> + * usb_decode_ctrl - Returns human readable representation of control request.
> + * @str: buffer to return a human-readable representation of control request.
> + *       This buffer should have about 200 bytes.
> + * @size: size of str buffer.
> + * @bRequestType: matches the USB bmRequestType field
> + * @bRequest: matches the USB bRequest field
> + * @wValue: matches the USB wValue field (CPU byte order)
> + * @wIndex: matches the USB wIndex field (CPU byte order)
> + * @wLength: matches the USB wLength field (CPU byte order)
> + *
> + * Function returns decoded, formatted and human-readable description of
> + * control request packet.
> + *
> + * The usage scenario for this is for tracepoints, so function as a return
> + * use the same value as in parameters. This approach allows to use this
> + * function in TP_printk
> + *
> + * Important: wValue, wIndex, wLength parameters before invoking this function
> + * should be processed by le16_to_cpu macro.
> + */
> +extern const char *usb_decode_ctrl(char *str, size_t size, __u8 bRequestType,
> +				   __u8 bRequest, __u16 wValue, __u16 wIndex,
> +				   __u16 wLength);
> +

where's the stub when !TRACING?

-- 
balbi