[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190708172944.GA24662@tower.DHCP.thefacebook.com>
Date: Mon, 8 Jul 2019 17:29:49 +0000
From: Roman Gushchin <guro@...com>
To: Tejun Heo <tj@...nel.org>
CC: Peng Wang <rocking@....edu.cn>,
"lizefan@...wei.com" <lizefan@...wei.com>,
"hannes@...xchg.org" <hannes@...xchg.org>,
"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: minor tweak for logic to get cgroup css
On Mon, Jul 08, 2019 at 09:42:43AM -0700, Tejun Heo wrote:
> On Wed, Jul 03, 2019 at 10:07:49AM +0800, Peng Wang wrote:
> > We could only handle the case that css exists
> > and css_try_get_online() fails.
>
> As css_tryget_online() can't handle NULL input, this is a bug fix.
> Can you please clarify that in the description?
- if (!css || !css_tryget_online(css))
+ if (css && !css_tryget_online(css))
If css == NULL, !css is true, and the second part of the || statement
will not be evaluated. So it's not a bug fix.
Thanks!
Powered by blists - more mailing lists