linux-kernel - Re: [PATCH] cgroup: minor tweak for logic to get cgroup css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190708173137.GH657710@devbig004.ftw2.facebook.com>
Date:   Mon, 8 Jul 2019 10:31:37 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Roman Gushchin <guro@...com>
Cc:     Peng Wang <rocking@....edu.cn>,
        "lizefan@...wei.com" <lizefan@...wei.com>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: minor tweak for logic to get cgroup css

On Mon, Jul 08, 2019 at 05:29:49PM +0000, Roman Gushchin wrote:
> On Mon, Jul 08, 2019 at 09:42:43AM -0700, Tejun Heo wrote:
> > On Wed, Jul 03, 2019 at 10:07:49AM +0800, Peng Wang wrote:
> > > We could only handle the case that css exists
> > > and css_try_get_online() fails.
> > 
> > As css_tryget_online() can't handle NULL input, this is a bug fix.
> > Can you please clarify that in the description?
> 
> -       if (!css || !css_tryget_online(css))
> +       if (css && !css_tryget_online(css))
> 
> If css == NULL, !css is true, and the second part of the || statement
> will not be evaluated. So it's not a bug fix.

Ah right, it's just confusing.  Will apply after the merge window.

Thanks.

-- 
tejun