linux-kernel - Re: [PATCH] selftests/ftrace: avoid failure when trying to probe a notrace function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190708145618.6649f397@gandalf.local.home>
Date:   Mon, 8 Jul 2019 14:56:18 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Shuah Khan <shuahkhan@...il.com>
Subject: Re: [PATCH] selftests/ftrace: avoid failure when trying to probe a
 notrace function

On Mon,  8 Jul 2019 15:19:33 -0300
Thadeu Lima de Souza Cascardo <cascardo@...onical.com> wrote:

> Check that the function is on available_filter_functions. If it's not,
> mark the test as unresolved, instead of failing it.
> 

Actually, I sent this out a while ago:

  http://lkml.kernel.org/r/20190322150923.1b58eca5@gandalf.local.home

Does that fix it for you?

-- Steve


> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
> ---
>  tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc
> index 3fb70e01b1fe..e4dff034da12 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_eventname.tc
> @@ -26,6 +26,7 @@ test -d events/kprobes2/event2 || exit_failure
>  
>  FUNC=`grep -m 10 " [tT] .*\.isra\..*$" /proc/kallsyms | tail -n 1 | cut -f 3 -d " "`
>  [ "x" != "x$FUNC" ] || exit_unresolved
> +grep -n "$FUNC" available_filter_functions || exit_unresolved
>  echo "p $FUNC" > kprobe_events
>  EVENT=`grep $FUNC kprobe_events | cut -f 1 -d " " | cut -f 2 -d:`
>  [ "x" != "x$EVENT" ] || exit_failure