[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1ac9c018-09c0-1123-ed97-b230a2117533@iogearbox.net>
Date: Tue, 9 Jul 2019 02:13:21 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Ilya Maximets <i.maximets@...sung.com>, netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
xdp-newbies@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Björn Töpel <bjorn.topel@...el.com>,
Magnus Karlsson <magnus.karlsson@...el.com>,
Jonathan Lemon <jonathan.lemon@...il.com>,
Jakub Kicinski <jakub.kicinski@...ronome.com>,
Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf v2] xdp: fix race on generic receive path
On 07/03/2019 02:09 PM, Ilya Maximets wrote:
> Unlike driver mode, generic xdp receive could be triggered
> by different threads on different CPU cores at the same time
> leading to the fill and rx queue breakage. For example, this
> could happen while sending packets from two processes to the
> first interface of veth pair while the second part of it is
> open with AF_XDP socket.
>
> Need to take a lock for each generic receive to avoid race.
>
> Fixes: c497176cb2e4 ("xsk: add Rx receive functions and poll support")
> Signed-off-by: Ilya Maximets <i.maximets@...sung.com>
Applied, thanks!
Powered by blists - more mailing lists