[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <156277086449.4055.15655120452619911756@skylake-alporthouse-com>
Date: Wed, 10 Jul 2019 16:01:04 +0100
From: Chris Wilson <chris@...is-wilson.co.uk>
To: Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>,
intel-gfx@...ts.freedesktop.org
Cc: Jani Nikula <jani.nikula@...ux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
MichaĆ Wajdeczko <michal.wajdeczko@...el.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
Subject: Re: [RFC PATCH] drm/i915: Drop extern qualifiers from header function
prototypes
Quoting Janusz Krzysztofik (2019-07-10 15:52:39)
> Follow dim checkpatch recommendation so it doesn't complain on that now
> and again on header file modifications.
>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2388,19 +2388,18 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> __i915_printk(dev_priv, KERN_ERR, fmt, ##__VA_ARGS__)
>
> #ifdef CONFIG_COMPAT
> -extern long i915_compat_ioctl(struct file *filp, unsigned int cmd,
> - unsigned long arg);
> +long i915_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
> #else
> #define i915_compat_ioctl NULL
> #endif
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct dev_pm_ops i915_pm_ops_1;
That's novel.
-Chris
Powered by blists - more mailing lists