linux-kernel - Re: [RFC PATCH] drm/i915: Drop extern qualifiers from header function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1625229.KzvQlO0Tx8@jkrzyszt-desk.ger.corp.intel.com>
Date:   Thu, 11 Jul 2019 08:28:55 +0200
From:   Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     intel-gfx@...ts.freedesktop.org,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Michał Wajdeczko <michal.wajdeczko@...el.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
Subject: Re: [RFC PATCH] drm/i915: Drop extern qualifiers from header function prototypes

Hi Chris,

On Wednesday, July 10, 2019 5:01:04 PM CEST Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-07-10 15:52:39)
> > Follow dim checkpatch recommendation so it doesn't complain on that now
> > and again on header file modifications.
> > 
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
> 
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2388,19 +2388,18 @@ __i915_printk(struct drm_i915_private *dev_priv, 
const char *level,
> >         __i915_printk(dev_priv, KERN_ERR, fmt, ##__VA_ARGS__)
> >  
> >  #ifdef CONFIG_COMPAT
> > -extern long i915_compat_ioctl(struct file *filp, unsigned int cmd,
> > -                             unsigned long arg);
> > +long i915_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long 
arg);
> >  #else
> >  #define i915_compat_ioctl NULL
> >  #endif
> >  extern const struct dev_pm_ops i915_pm_ops;
> > +extern const struct dev_pm_ops i915_pm_ops_1;
> 
> That's novel.

Oh, sorry, that was my testing of how dim checkpatch reacts on extern 
qualifiers on variables.  Thanks for catching this.

Janusz

> > -Chris
>