linux-kernel - RE: [PATCH] ahci: Remove the exporting of ahci_em

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27240C0AC20F114CBF8149A2696CBE4A60BCAAEE@SHSMSX106.ccr.corp.intel.com>
Date:   Thu, 11 Jul 2019 01:03:51 +0000
From:   "Liu, Chuansheng" <chuansheng.liu@...el.com>
To:     Denis Efremov <efremov@...ux.com>
CC:     Jens Axboe <axboe@...nel.dk>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ahci: Remove the exporting of ahci_em_messages



> -----Original Message-----
> From: Denis Efremov [mailto:efremov@...ux.com]
> Sent: Wednesday, July 10, 2019 11:29 PM
> To: Liu, Chuansheng <chuansheng.liu@...el.com>
> Cc: Denis Efremov <efremov@...ux.com>; Jens Axboe <axboe@...nel.dk>;
> linux-ide@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
> 
> The variable ahci_em_messages is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> variable is not used outside of the drivers/ata/libahci.c file it is
> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Sounds good to me, thanks.
Reviewed-by: Chuansheng Liu <chuansheng.liu@...ux.intel.com>