linux-kernel - Re: [PATCH] ahci: Remove the exporting of ahci_em

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <340001e6-1750-b6b5-9482-3843679acb63@linux.com>
Date:   Wed, 14 Aug 2019 00:44:55 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "Liu, Chuansheng" <chuansheng.liu@...el.com>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH] ahci: Remove the exporting of ahci_em_messages

Hi Jens,

On 11.07.2019 04:03, Liu, Chuansheng wrote:
>> -----Original Message-----
>> From: Denis Efremov [mailto:efremov@...ux.com]
>> Sent: Wednesday, July 10, 2019 11:29 PM
>> To: Liu, Chuansheng <chuansheng.liu@...el.com>
>> Cc: Denis Efremov <efremov@...ux.com>; Jens Axboe <axboe@...nel.dk>;
>> linux-ide@...r.kernel.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>>
>> The variable ahci_em_messages is declared static and marked
>> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
>> variable is not used outside of the drivers/ata/libahci.c file it is
>> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
> 
> Sounds good to me, thanks.
> Reviewed-by: Chuansheng Liu <chuansheng.liu@...ux.intel.com>
> 

Could you please look at this patch once again and accept it if it's ok?
static ahci_em_messages will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118

Thanks,
Denis