[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ac0700a1-0984-417b-d5d8-35c4ba56f6f6@gmail.com>
Date: Thu, 11 Jul 2019 04:17:47 +0300
From: Pavel Begunkov <asml.silence@...il.com>
To: Josef Bacik <josef@...icpanda.com>
Cc: Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, dennis@...nel.org
Subject: Re: [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Hi,
Any thoughts? Is there something wrong with the patchset?
On 29/06/2019 18:37, Pavel Begunkov wrote:
> Ping?
>
> On 20/06/2019 10:18, Pavel Begunkov wrote:
>> Hi,
>>
>> Josef, thanks for taking a look.
>>
>>
>> Although, there is nothing critical yet -- just a not working / disabled
>> optimisation, but changes in stats could sublty break it. E.g. grouping
>> @batch and @mean into a union will increase estimated average by several
>> orders of magnitude.
>>
>> Jens, what do you think?
>>
>>
>>
>> On 14/06/2019 16:40, Josef Bacik wrote:
>>> On Fri, Jun 14, 2019 at 02:44:11PM +0300, Pavel Begunkov (Silence) wrote:
>>>> From: Pavel Begunkov <asml.silence@...il.com>
>>>>
>>>> There are implicit assumptions about struct blk_rq_stats, which make
>>>> it's very easy to misuse. The first patch fixes consequences, and the
>>>> second employs type-system to prevent recurrences.
>>>>
>>>>
>>>> Pavel Begunkov (2):
>>>> blk-iolatency: Fix zero mean in previous stats
>>>> blk-stats: Introduce explicit stat staging buffers
>>>>
>>>
>>> I don't have a problem with this, but it's up to Jens I suppose
>>>
>>> Acked-by: Josef Bacik <josef@...icpanda.com>
>>>
>>> Thanks,
>>>
>>> Josef
>>>
>>
>
--
Yours sincerely,
Pavel Begunkov
Powered by blists - more mailing lists