lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Jul 2019 16:52:04 -0700 From: James Bottomley <jejb@...ux.ibm.com> To: Keyur Patel <iamkeyur96@...il.com> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons On Thu, 2019-07-11 at 19:48 -0400, Keyur Patel wrote: > Change (x == NULL) to !x and (x != NULL) to x, to fix > following checkpatch.pl warnings: > CHECK: Comparison to NULL could be written "!x". This is one of our significantly older drivers. We try not to touch it unless we really have to, so I'd rather not have patches like this applied to it. I also don't really think the replacement adds anything to readability, so it should probably be removed from the checkpatch warnings. Thanks, James
Powered by blists - more mailing lists