linux-kernel - Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq17e8o84tm.fsf@oracle.com>
Date:   Thu, 11 Jul 2019 20:38:45 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     James Bottomley <jejb@...ux.ibm.com>
Cc:     Keyur Patel <iamkeyur96@...il.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons


James,

> I also don't really think the replacement adds anything to readability,
> so it should probably be removed from the checkpatch warnings.

I agree.

-- 
Martin K. Petersen	Oracle Linux Engineering