linux-kernel - Re: [PATCH v3] gpu/drm_memory: fix a few warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Jul 2019 15:45:35 -0400
From:   Qian Cai <cai@....pw>
To:     akpm@...ux-foundation.org
Cc:     imirkin@...m.mit.edu, airlied@...ux.ie, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, sean@...rly.run,
        joe@...ches.com, rfontana@...hat.com, tglx@...utronix.de,
        torvalds@...ux-foundation.org, corbet@....net,
        gregkh@...uxfoundation.org, linux-spdx@...hiver.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] gpu/drm_memory: fix a few warnings

Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
this as there is no feedback from any of them for months since v1.

On Tue, 2019-07-09 at 11:13 -0400, Qian Cai wrote:
> The opening comment mark "/**" is reserved for kernel-doc comments, so
> it will generate a warning with "make W=1".
> 
> drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand  * \file
> drm_memory.c
> 
> Also, silence a checkpatch warning by adding a license identfiter where
> it indicates the MIT license further down in the source file.
> 
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Fix it by adding the MIT SPDX identifier without touching the boilerplate
> language.
> 
> Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Qian Cai <cai@....pw>
> ---
> 
> v3: Keep the boilerplate language.
> v2: Remove the redundant description of the license.
> 
>  drivers/gpu/drm/drm_memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 132fef8ff1b6..683042c8ee2c 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -1,4 +1,5 @@
> -/**
> +// SPDX-License-Identifier: MIT
> +/*
>   * \file drm_memory.c
>   * Memory management wrappers for DRM
>   *