linux-kernel - Re: [PATCH v3] gpu/drm_memory: fix a few warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190715110228.GD20839@arch-x1c3>
Date:   Mon, 15 Jul 2019 12:02:28 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Qian Cai <cai@....pw>
Cc:     akpm@...ux-foundation.org, corbet@....net, airlied@...ux.ie,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, rfontana@...hat.com,
        gregkh@...uxfoundation.org, joe@...ches.com,
        linux-spdx@...hiver.kernel.org, tglx@...utronix.de, sean@...rly.run
Subject: Re: [PATCH v3] gpu/drm_memory: fix a few warnings

Hi Qian,

On 2019/07/12, Qian Cai wrote:
> Maybe one of the non-DRM maintainers (Andrew, Thomas or Greg) who cares a bit
> about SPDX can pick this up. It occurs to me none of DRM maintainers cares about
> this as there is no feedback from any of them for months since v1.
> 
AFAICT there are a couple of reasons why this has gone unnoticed:
 - summary is the pretty ambiguous
 - commit does two thigs

Another thing to consider is that this patch touches a single file,
while the exact same issue is also present in many other files.

Quick look at the following lists:
head -n2 drivers/gpu/drm/drm_*[ch]  | less

drm_agpsupport.c
drm_dma.c
drm_legacy_misc.c
drm_lock.c
drm_memory.c
drm_scatter.c
drm_vm.c

If you can fixup the s|/**|/*| in the above, I'd gladly merge the patch.

On the topic of SPDX - no objection on my end, but it should be a
separate patch, which replaces the explicit verbose license text with
the tag.

Thanks
Emil