linux-kernel - Re: [PATCH] Input: iforce - Remove empty multiline comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 14 Jul 2019 14:29:03 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Tim Schumacher <timschumi@....de>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH] Input: iforce - Remove empty multiline comments

On Mon, Jul 08, 2019 at 04:50:10AM +0200, Tim Schumacher wrote:
> Those are remnants of the SPDX identifier migration, which haven't been
> removed properly.
> 
> Signed-off-by: Tim Schumacher <timschumi@....de>

Applied, thank you.

> ---
> This is probably the highest level of cosmetic-only that a patch
> can achieve, sorry for the noise.
> 
> CCing Thomas Gleixner, since the tool (is it a tool?) that makes
> those SPDX changes would have room for improvement in that regard.
> It seems to expect that all of the license information is contained
> within the same comment block, which wasn't the case for the iforce
> driver.
> ---
>  drivers/input/joystick/iforce/iforce-ff.c      | 3 ---
>  drivers/input/joystick/iforce/iforce-main.c    | 3 ---
>  drivers/input/joystick/iforce/iforce-packets.c | 3 ---
>  drivers/input/joystick/iforce/iforce-serio.c   | 3 ---
>  drivers/input/joystick/iforce/iforce-usb.c     | 3 ---
>  drivers/input/joystick/iforce/iforce.h         | 3 ---
>  6 files changed, 18 deletions(-)
> 
> diff --git a/drivers/input/joystick/iforce/iforce-ff.c b/drivers/input/joystick/iforce/iforce-ff.c
> index 2ed7da7d1f3e..4350927f7781 100644
> --- a/drivers/input/joystick/iforce/iforce-ff.c
> +++ b/drivers/input/joystick/iforce/iforce-ff.c
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include "iforce.h"
> 
>  /*
> diff --git a/drivers/input/joystick/iforce/iforce-main.c b/drivers/input/joystick/iforce/iforce-main.c
> index 55f5b7bb4cac..8c2ffa43ce89 100644
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include "iforce.h"
> 
>  MODULE_AUTHOR("Vojtech Pavlik <vojtech@....cz>, Johann Deneux <johann.deneux@...il.com>");
> diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
> index 42cd9730e4cc..677a7773059d 100644
> --- a/drivers/input/joystick/iforce/iforce-packets.c
> +++ b/drivers/input/joystick/iforce/iforce-packets.c
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include "iforce.h"
> 
>  static struct {
> diff --git a/drivers/input/joystick/iforce/iforce-serio.c b/drivers/input/joystick/iforce/iforce-serio.c
> index 65a4fe26324f..b3fff64d92dd 100644
> --- a/drivers/input/joystick/iforce/iforce-serio.c
> +++ b/drivers/input/joystick/iforce/iforce-serio.c
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include "iforce.h"
> 
>  void iforce_serial_xmit(struct iforce *iforce)
> diff --git a/drivers/input/joystick/iforce/iforce-usb.c b/drivers/input/joystick/iforce/iforce-usb.c
> index f1569ae8381b..ec5058e05317 100644
> --- a/drivers/input/joystick/iforce/iforce-usb.c
> +++ b/drivers/input/joystick/iforce/iforce-usb.c
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include "iforce.h"
> 
>  void iforce_usb_xmit(struct iforce *iforce)
> diff --git a/drivers/input/joystick/iforce/iforce.h b/drivers/input/joystick/iforce/iforce.h
> index f1681706f526..32e91baf63f5 100644
> --- a/drivers/input/joystick/iforce/iforce.h
> +++ b/drivers/input/joystick/iforce/iforce.h
> @@ -6,9 +6,6 @@
>   *  USB/RS232 I-Force joysticks and wheels.
>   */
> 
> -/*
> - */
> -
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/input.h>
> --
> 2.22.0
> 

-- 
Dmitry