linux-kernel - Re: m68k: One function call less in cf_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU+sDjiTZph1gfii=WoWQ2c+jTvvqjq4mVSbFAi0eb_VA@mail.gmail.com>
Date:   Sun, 14 Jul 2019 23:14:53 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        kernel-janitors@...r.kernel.org,
        Finn Thain <fthain@...egraphics.com.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Michal Hocko <mhocko@...e.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: m68k: One function call less in cf_tlb_miss()

Hi Markus,

On Sun, Jul 14, 2019 at 6:06 PM Markus Elfring <Markus.Elfring@....de> wrote:
> >>> Avoid an extra function call by using a ternary operator
> >>> instead of a conditional statement for a setting selection.
> >
> > Have you looked at the actual assembler output generated by the compiler?
>
> Not yet.

You better do, it can be a good learning experience!

> * Can the suggested small refactoring matter for a specific software combination there?
> * Would you like to clarify this change possibility a bit more?

-EPARSE

No need to relay my emails through https://en.wikipedia.org/wiki/ELIZA ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds