linux-kernel - Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Jul 2019 17:36:53 +0900
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     john.hubbard@...il.com
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        devel@...verdev.osuosl.org, Vandana BN <bnvandana@...il.com>,
        Geordan Neukum <gneukum1@...il.com>,
        Bharath Vedartham <linux.bhar@...il.com>,
        John Hubbard <jhubbard@...dia.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Simon Sandström <simon@...anor.nu>
Subject: Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@...il.com wrote:
> From: John Hubbard <jhubbard@...dia.com>
> 
> This commit was created by running indent(1):
>     `indent -linux`
> 
> ...and then applying some manual corrections and
> cleanup afterward, to keep it sane. No functional changes
> were made.
> 
> In addition to whitespace changes, some strings were split,
> but not strings that were likely to be a grep problem
> (in other words, if a user is likely to grep for a string
> within the driver, that should still work in most cases).
> 
> A few "void * foo" cases were fixed to be "void *foo".
> 
> That was enough to make checkpatch.pl run without errors,
> although note that there are lots of serious warnings
> remaining--but those require functional, not just whitespace
> changes. So those are left for a separate patch.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Simon Sandström <simon@...anor.nu>
> Cc: Geordan Neukum <gneukum1@...il.com>
> Cc: Jeremy Sowden <jeremy@...zel.net>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Vandana BN <bnvandana@...il.com>
> Cc: devel@...verdev.osuosl.org
> Cc: Bharath Vedartham <linux.bhar@...il.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
>  drivers/staging/kpc2000/kpc2000_i2c.c         | 189 +++++++++++------
>  drivers/staging/kpc2000/kpc2000_spi.c         | 116 +++++-----
>  drivers/staging/kpc2000/kpc_dma/dma.c         | 109 ++++++----
>  drivers/staging/kpc2000/kpc_dma/fileops.c     | 199 +++++++++++-------
>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  | 113 +++++-----
>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.h  | 156 +++++++-------
>  6 files changed, 509 insertions(+), 373 deletions(-)

THat's way too many different types of changes to do all at once, and
some of these are making the code look worse, not better.

There's a reason we don't run lindent :)

If you want to do one-type-of-fix-per-patch, I'll gladly take these,
otherwise, I recommend leaving this for those people learning how to do
development to do.

thanks,

greg k-h