linux-kernel - Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76dbf8b5-6819-46d6-3e88-6efd3e65c10f@nvidia.com>
Date:   Tue, 16 Jul 2019 11:02:30 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <john.hubbard@...il.com>
CC:     Dan Carpenter <dan.carpenter@...cle.com>,
        <devel@...verdev.osuosl.org>, Vandana BN <bnvandana@...il.com>,
        Geordan Neukum <gneukum1@...il.com>,
        Bharath Vedartham <linux.bhar@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Simon Sandström <simon@...anor.nu>
Subject: Re: [PATCH] staging: kpc2000: whitespace and line length cleanup

On 7/16/19 1:36 AM, Greg Kroah-Hartman wrote:
> On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@...il.com wrote:
>> From: John Hubbard <jhubbard@...dia.com>
...
>>  drivers/staging/kpc2000/kpc2000_i2c.c         | 189 +++++++++++------
>>  drivers/staging/kpc2000/kpc2000_spi.c         | 116 +++++-----
>>  drivers/staging/kpc2000/kpc_dma/dma.c         | 109 ++++++----
>>  drivers/staging/kpc2000/kpc_dma/fileops.c     | 199 +++++++++++-------
>>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.c  | 113 +++++-----
>>  .../staging/kpc2000/kpc_dma/kpc_dma_driver.h  | 156 +++++++-------
>>  6 files changed, 509 insertions(+), 373 deletions(-)
> 
> THat's way too many different types of changes to do all at once, and
> some of these are making the code look worse, not better.
> 
> There's a reason we don't run lindent :)

Yes, I am seeing that very clearly now. :)

> 
> If you want to do one-type-of-fix-per-patch, I'll gladly take these,
> otherwise, I recommend leaving this for those people learning how to do
> development to do.
> 

OK, I'm going to pretend that I'm not one of those people, despite recent
hard evidence to the contrary here. haha. Anyway, this does present a
nice set of things for new developers to get started on. So I'll leave
it as is.

thanks,
-- 
John Hubbard
NVIDIA