linux-kernel - Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FC18511-DD19-4B10-BCAF-906E264B0411@vmware.com>
Date:   Thu, 18 Jul 2019 17:02:07 +0000
From:   Nadav Amit <namit@...are.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     Wei Wang <wei.w.wang@...el.com>, Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kvm list <kvm@...r.kernel.org>,
        Xavier Deguillard <xdeguillard@...are.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "pagupta@...hat.com" <pagupta@...hat.com>,
        Rik van Riel <riel@...riel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        David Hildenbrand <david@...hat.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        "yang.zhang.wz@...il.com" <yang.zhang.wz@...il.com>,
        "nitesh@...hat.com" <nitesh@...hat.com>,
        "lcapitulino@...hat.com" <lcapitulino@...hat.com>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "alexander.h.duyck@...ux.intel.com" 
        <alexander.h.duyck@...ux.intel.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>
Subject: Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

> On Jul 18, 2019, at 5:26 AM, Michael S. Tsirkin <mst@...hat.com> wrote:
> 
> On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
>> Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
>> 
>> A #GP is reported in the guest when requesting balloon inflation via
>> virtio-balloon. The reason is that the virtio-balloon driver has
>> removed the page from its internal page list (via balloon_page_pop),
>> but balloon_page_enqueue_one also calls "list_del"  to do the removal.
>> This is necessary when it's used from balloon_page_enqueue_list, but
>> not from balloon_page_enqueue_one.
>> 
>> So remove the list_del balloon_page_enqueue_one, and update some
>> comments as a reminder.
>> 
>> Signed-off-by: Wei Wang <wei.w.wang@...el.com>
> 
> 
> ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look.

Thanks (Wei, Michael) for taking care of it. Please cc me on future
iterations of the patch.

Acked-by: Nadav Amit <namit@...are.com>