linux-kernel - Re: get_maintainers.pl subsystem output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jul 2019 07:31:16 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Duda, Sebastian" <sebastian.duda@....de>
Cc:     linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com,
        ralf.ramsauer@...-regensburg.de, wolfgang.mauerer@...-regensburg.de
Subject: Re: get_maintainers.pl subsystem output

On Fri, 2019-07-19 at 09:54 +0000, Duda, Sebastian wrote:
> On 2019-07-19 08:50, Joe Perches wrote:

> > > My Questions are:
> > > 1. How can I make get_maintainer's output to be more table-like?
> > 
> > I suggest adding --nogit --nogit-fallback --roles --norolestats
> 
> Unfortunately, this doesn't change the output:
>      $ scripts/get_maintainer.pl --subsystem --status --separator , 
> drivers/media/i2c/adv748x/
>      Kieran Bingham <kieran.bingham@...asonboard.com> (maintainer:ANALOG 
> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org> 
> (maintainer:MEDIA INPUT INFRASTRUCTURE 
> (V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC 
> ADV748X DRIVER),linux-kernel@...r.kernel.org (open list)
>      Maintained,Buried alive in reporters
>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
> (V4L/DVB),THE REST

It does change the output for files that do not
have a specific maintainer.

> > > 2. How can I make get_maintainer.pl to separate each file's output?
> > 
> > Run the script with multiple invocations. once for each file
> > modified by the patch.
> 
> This is the way I'm doing it right now but this is very slow. I thought 
> calling the script only once for many files could speed up the analysis.

get_maintainer is effectively single threaded.

Averaging 10 runs:

A single file run time is ~0.135 seconds on my system.
An invocation with two files on the command line has
a run time of ~0.195 seconds.

Using something like gnu parallel would allow multiple
instances to run simulateously and would significantly
reduce overall wall-clock runtime on most systems.

https://www.gnu.org/software/parallel/