linux-kernel - Re: get_maintainers.pl subsystem output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6fa4aa44f343616459b17054197d0a22@fau.de>
Date:   Fri, 19 Jul 2019 09:54:31 +0000
From:   "Duda, Sebastian" <sebastian.duda@....de>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org, lukas.bulwahn@...il.com,
        ralf.ramsauer@...-regensburg.de, wolfgang.mauerer@...-regensburg.de
Subject: Re: get_maintainers.pl subsystem output

On 2019-07-19 08:50, Joe Perches wrote:
> On Fri, 2019-07-19 at 07:35 +0000, Duda, Sebastian wrote:
>> Hi Joe,
>> 
>> I'm conducting a large-scale patch analysis of the LKML with 1.8 
>> million
>> patch emails. I'm using the `get_maintainer.pl` script to know which
>> patch is related to which subsystem.
> 
> The MAINTAINERS file is updated frequently.
> 
> Are you also using the MAINTAINERS file used
> at the time each patch was submitted?

Yes, for each patch we use the MAINTAINERS file from the current (by the 
time the patch was submitted) release (candidate).

>> I ran into two issues while using the script:
>> 
>> 1. When I use the script the trivial way
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ,
>> drivers/media/i2c/adv748x/
>>      Kieran Bingham <kieran.bingham@...asonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@...r.kernel.org (open list)
>>      Maintained,Buried alive in reporters
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST
>> 
>> the output is hard to parse because the status `Maintained` is 
>> displayed
>> only once but related to two subsystems.
>> 
>> I'd prefer a more table like representation, like this:
>> 
>>      Kieran Bingham <kieran.bingham@...asonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),linux-media@...r.kernel.org (open
>> list:ANALOG DEVICES INC ADV748X DRIVER),ANALOG DEVICES INC ADV748X
>> DRIVER,Maintained
>>      Mauro Carvalho Chehab <mchehab@...nel.org> (maintainer:MEDIA 
>> INPUT
>> INFRASTRUCTURE (V4L/DVB)),MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),Maintained
>>      linux-kernel@...r.kernel.org (open list),THE REST,Buried alive in
>> reporters
>> 
>> 
>> 2. I want to analyze multiple patches, currently I am calling the 
>> script
>> once per patch. When calling the script with multiple files the files
>> output is merged
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ','
>> drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
>>      Kieran Bingham <kieran.bingham@...asonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@...r.kernel.org (open
>> list),platform-driver-x86@...r.kernel.org (open list:ACPI WMI DRIVER)
>>      Maintained,Buried alive in reporters,Orphan
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST,ACPI WMI DRIVER
>> 
>> I'd like to run the script with all files but separated output, like
>> this:
>> 
>>      $ scripts/get_maintainer.pl --subsystem --status --separator ','
>> --separate-files drivers/media/i2c/adv748x/ include/uapi/linux/wmi.h
>>      Kieran Bingham <kieran.bingham@...asonboard.com> 
>> (maintainer:ANALOG
>> DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org>
>> (maintainer:MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC
>> ADV748X DRIVER),linux-kernel@...r.kernel.org (open list)
>>      Maintained,Buried alive in reporters
>>      ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE
>> (V4L/DVB),THE REST
>> 
>>      platform-driver-x86@...r.kernel.org (open list:ACPI WMI
>> DRIVER),linux-kernel@...r.kernel.org (open list)
>>      Orphan,Buried alive in reporters
>>      ACPI WMI DRIVER,THE REST
>> 
>> 
>> My Questions are:
>> 1. How can I make get_maintainer's output to be more table-like?
> 
> I suggest adding --nogit --nogit-fallback --roles --norolestats

Unfortunately, this doesn't change the output:
     $ scripts/get_maintainer.pl --subsystem --status --separator , 
drivers/media/i2c/adv748x/
     Kieran Bingham <kieran.bingham@...asonboard.com> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC 
ADV748X DRIVER),linux-kernel@...r.kernel.org (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

     $ scripts/get_maintainer.pl --subsystem --status --separator , 
--nogit --nogit-fallback --roles --norolestats 
drivers/media/i2c/adv748x/
     Kieran Bingham <kieran.bingham@...asonboard.com> (maintainer:ANALOG 
DEVICES INC ADV748X DRIVER),Mauro Carvalho Chehab <mchehab@...nel.org> 
(maintainer:MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB)),linux-media@...r.kernel.org (open list:ANALOG DEVICES INC 
ADV748X DRIVER),linux-kernel@...r.kernel.org (open list)
     Maintained,Buried alive in reporters
     ANALOG DEVICES INC ADV748X DRIVER,MEDIA INPUT INFRASTRUCTURE 
(V4L/DVB),THE REST

>> 2. How can I make get_maintainer.pl to separate each file's output?
> 
> Run the script with multiple invocations. once for each file
> modified by the patch.

This is the way I'm doing it right now but this is very slow. I thought 
calling the script only once for many files could speed up the analysis.

Thank you
Sebastian