linux-kernel - Re: [PATCH] gve: replace kfree with kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH_-1qwjgoi7Yve0s1NS1oEKXmxu3V5SPZMzy-Wwux-gM0Pf+Q@mail.gmail.com>
Date:   Fri, 19 Jul 2019 10:44:54 -0700
From:   Catherine Sullivan <csully@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     chuhongyuan@...look.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gve: replace kfree with kvfree

On Thu, Jul 18, 2019 at 4:32 PM David Miller <davem@...emloft.net> wrote:
>
> From: Chuhong YUAN <chuhongyuan@...look.com>
> Date: Wed, 17 Jul 2019 00:59:02 +0000
>
> > Variables allocated by kvzalloc should not be freed by kfree.
> > Because they may be allocated by vmalloc.
> > So we replace kfree with kvfree here.
> >
> > Signed-off-by: Chuhong Yuan <chuhongyuan@...look.com>
>
> Applied, thanks Chuhong.
>
> GVE maintainers, you are upstream now and have to stay on top of review
> of changes like this.  Otherwise I'll just review it myself and apply
> it unless I find problems, and that may not be what you want :)

Will do, thanks for the review. And thanks for the fix Chuhong.