linux-kernel - Re: [PATCH] fuse: cleanup fuse_wait_on_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jul 2019 10:18:39 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Miklos Szeredi <miklos@...redi.hu>
Subject: Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback

I forget to add this patch was used in OpenVZ kernels last few years.

On 7/22/19 10:17 AM, Vasily Averin wrote:
> From: Maxim Patlasov <mpatlasov@...tuozzo.com>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.
> 
> Signed-off-by: Maxim Patlasov <mpatlasov@...tuozzo.com>
> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> ---
>  fs/fuse/file.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5ae2828beb00..e076c2cf65b0 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
>   * Since fuse doesn't rely on the VM writeback tracking, this has to
>   * use some other means.
>   */
> -static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> +static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
>  {
>  	struct fuse_inode *fi = get_fuse_inode(inode);
>  
>  	wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
> -	return 0;
>  }
>  
>  /*
>