linux-kernel - Re: [PATCH v4 1/3] driver core: platform: Add an error message to platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d38a0d1.1c69fb81.4e830.7802@mx.google.com>
Date:   Wed, 24 Jul 2019 11:17:52 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Markus Elfring <Markus.Elfring@....de>,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Andrzej Hajda <a.hajda@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH v4 1/3] driver core: platform: Add an error message to platform_get_irq*()

Quoting Markus Elfring (2019-07-24 08:00:43)
> > Let's consolidate all these error messages into the API itself,
> > allowing us to get rid of the error messages in each driver.
> 
> Such information from the commit descriptions sounds positive.
> 
> 
> > +++ b/drivers/base/platform.c
> …
> > @@ -163,6 +158,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
> …
> > +/**
> > + * platform_get_irq - get an IRQ for a device
> > + * @dev: platform device
> > + * @num: IRQ number index
> > + */
> 
> Do you find the provided description for the programming interface
> really sufficient then?
> Would it be more helpful to indicate the existence of an appropriate error message
> also in this software documentation (besides the C source code)?
> 

Sure. I'll add some more documentation in this patch too so that
developers can easily see that they shouldn't print an error message
themselves.