linux-kernel - Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190724170803.GE4524@sirena.org.uk>
Date:   Wed, 24 Jul 2019 18:08:03 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after
 platform_get_irq()

On Tue, Jul 23, 2019 at 03:24:53PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2019-07-23 12:30:48)

> > There's also some cases that the irq seems to be optional. They use
> > dev_info, but will now have an error level print. That's fine with me,
> > but some may complain...

> Yeah I wonder if there should be a platform_get_irq_optional() API that
> more explicitly indicates this and then doesn't print a warning when the
> irq isn't there.

I think that'd be a good solution.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)