[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190724040743.GB12733@vkoul-mobl.Dlink>
Date: Wed, 24 Jul 2019 09:37:43 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node
On 23-07-19, 07:50, Stephen Boyd wrote:
> Quoting Vinod Koul (2019-07-22 05:34:18)
> > We get a warning about missing unit name for soc node, so add it.
> >
> > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
Thanks for the review
>
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 601cfb078bd5..e81f4a6d08ce 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -620,7 +620,7 @@
> > method = "smc";
> > };
> >
> > - soc: soc {
> > + soc: soc@0 {
>
> This is kinda sad, but ok. Maybe you can apply this fix to at least all
> the qcom boards then.
Yeah that is the idea, start with sdm845 and 'reduce' the warns on all
qcom dts files
--
~Vinod
Powered by blists - more mailing lists