linux-kernel - [PATCH] x86/crash: remove unnecessary comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jul 2019 00:13:37 -0400
From:   Nikolas Nyby <nikolas@....org>
To:     tglx@...utronix.de, x86@...nel.org, linux-kernel@...r.kernel.org
Cc:     Nikolas Nyby <nikolas@....org>
Subject: [PATCH] x86/crash: remove unnecessary comparison

This ret comparison and return are unnecessary as of
f296f2634920d205b93d878b48d87bb7e0a4c256

elf_header_exclude_ranges() returns ret in any case, with or
without this comparison.

Signed-off-by: Nikolas Nyby <nikolas@....org>
---
 arch/x86/kernel/crash.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 2bf70a2fed90..eb651fbde92a 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -225,8 +225,6 @@ static int elf_header_exclude_ranges(struct crash_mem *cmem)
 	if (crashk_low_res.end) {
 		ret = crash_exclude_mem_range(cmem, crashk_low_res.start,
 							crashk_low_res.end);
-		if (ret)
-			return ret;
 	}
 
 	return ret;
-- 
2.20.1