linux-kernel - Re: [PATCH v5 00/26] Add generic support for composing LED class device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d8890a2-47e8-2dd0-9764-93676703df2a@gmail.com>
Date:   Wed, 24 Jul 2019 23:02:52 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-leds@...r.kernel.org, dmurphy@...com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, dtor@...gle.com, linux@...ck-us.net
Subject: Re: [PATCH v5 00/26] Add generic support for composing LED class
 device name

On 7/18/19 12:52 PM, Pavel Machek wrote:
> 
>> Hi all,
>>
>> I need explicit acks for some patches from this series, that
>> were either requested improvements or I modified them by myself
>> after v4.
>>
>> The patches I am talking about are the following:
>>
>> 1/26
>> 21/26
>> 23/26
>> 25/26
> 
> Acked-by: Pavel Machek <pavel@....cz>

Applied the patch set without patch 26/26 for now.
I had to make some formatting related changes in leds-class.rst, in
part of the added text (we had leds-class.txt -> leds-class.rst
transition in the meantime) to fix resulting html formatting.
Basically they aimed to achieve nice bullets to compensate some
sphinx issue related to lack of line breaks after quoted strings.

Current shape of leds-class.rst on linux-leds.git for-next branch can
be looked up via [0].

>> 26/26 would be nice to have but I presume it needs more discussion
>> and analysis.
> 
> Idea is good, but I'd sort the file in different way.
> 
> Best regards,
> 									Pavel
> 

[0]
https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/tree/Documentation/leds/leds-class.rst?h=for-next

-- 
Best regards,
Jacek Anaszewski