linux-kernel - Re: [v4 2/3] treewide: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a69aeff9-338c-a763-3a25-3ff767e5401d@web.de>
Date:   Wed, 24 Jul 2019 13:17:39 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Stephen Boyd <swboyd@...omium.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        cocci@...teme.lip6.fr, kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Andrzej Hajda <a.hajda@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mark Brown <broonie@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [v4 2/3] treewide: Remove dev_err() usage after
 platform_get_irq()

> > > struct platform_device *E;

How much does this specification matter for the parameters
of the mentioned functions (in the SmPL script)?
Will the selection of function names be sufficient for the discussed
source code search pattern?


> > Can you teach it to remove curly braces when it's appropriate?
> > (see below for examples)
>
> I don't know if that works.

Such an adjustment depends on additional development efforts.


> Is there some sort of tidy script I can run on my patches to do this?

You can add corresponding case distinctions to your transformation approach
for the semantic patch language (on demand), can't you?

Regards,
Markus