linux-kernel - Re: [PATCH 2/2] Revert "media: vimc: propagate pixel format in the stream"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47703594-f336-3006-5ae0-7b459e48110f@xs4all.nl>
Date:   Thu, 25 Jul 2019 10:04:38 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Helen Koike <helen.koike@...labora.com>,
        linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...labora.com,
        skhan@...uxfoundation.org
Subject: Re: [PATCH 2/2] Revert "media: vimc: propagate pixel format in the
 stream"

Hi Helen,

On 7/9/19 9:43 PM, Helen Koike wrote:
> This reverts commit b6c61a6c37317efd7327199bfe24770af3d7e799.
> 
> The requested pixelformat is being propagated from the capture to the
> tpg in the sensor.
> 
> This was a bad design choice, as we start having the following issues:
> 
> * We set a pixelformat in the capture;
> * We set matching media bus formats in the subdevices pads;
> * Link validate looks fine (sizes matches, media bus formats matches);
> * Issue: if some of the subdevice doesn't know how to generate the
> requested pixelformat in the capture, then stream_on fails. This is bad
> because capture says it supports that pixelformat, everything looks
> fine, but it is not, and there is no way to find it out through the
> links.
> 
> This patch was implemented so we could request any pixelformat from the
> pipeline regardeless of the media bus format configured between pads.
> Not all pixelformat can be mapped into a media bus code (e.g.
> multiplanar formats), so with this patch we could request those
> pixelformats from the tpg.
> 
> Solution: map pixelformats to media bus codes as before, and implement
> conversions to other pixelformats in the capture to support multiplanar.
> 
> So first step to this solution is to revert this patch.
> 
> Signed-off-by: Helen Koike <helen.koike@...labora.com>
> ---
>  drivers/media/platform/vimc/vimc-capture.c  |  76 ++---
>  drivers/media/platform/vimc/vimc-common.c   | 309 ++++++++++++--------
>  drivers/media/platform/vimc/vimc-common.h   |  58 ++--
>  drivers/media/platform/vimc/vimc-debayer.c  |  83 ++----
>  drivers/media/platform/vimc/vimc-scaler.c   |  63 ++--
>  drivers/media/platform/vimc/vimc-sensor.c   |  51 +++-
>  drivers/media/platform/vimc/vimc-streamer.c |   2 -
>  drivers/media/platform/vimc/vimc-streamer.h |   6 -
>  8 files changed, 342 insertions(+), 306 deletions(-)
> 

Unfortunately this patch no longer applies.

Can you respin this series?

Also, should this be backported to 5.3 as well?

Regards,

	Hans