linux-kernel - Re: [PATCH 0/1] This patch fixes connection detection for monitors w/o DDC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190725113237.d2dwxzientte4j3n@flea>
Date:   Thu, 25 Jul 2019 13:32:37 +0200
From:   "maxime.ripard@...e-electrons.com" <maxime.ripard@...e-electrons.com>
To:     Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Igor Opaniuk <igor.opaniuk@...adex.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Jonas Karlman <jonas@...boo.se>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH 0/1] This patch fixes connection detection for monitors
 w/o DDC.

65;5603;1c
On Thu, Jul 25, 2019 at 11:05:23AM +0000, Oleksandr Suvorov wrote:
>
> Even in source code of this driver there is an author's description:
>     /*
>      * Even if we have an I2C bus, we can't assume that the cable
>      * is disconnected if drm_probe_ddc fails. Some cables don't
>      * wire the DDC pins, or the I2C bus might not be working at
>      * all.
>      */
>
> That's true. DDC and VGA channels are independent, and therefore
> we cannot decide whether the monitor is connected or not,
> depending on the information from the DDC.
>
> So the monitor should always be considered connected.

Well, no. Like you said, we cannot decided whether is connected or
not.

> Thus there is no reason to use connector detect callback for this
> driver: DRM sub-system considers monitor always connected if there
> is no detect() callback registered with drm_connector_init().
>
> How to reproduce the bug:
> * setup: i.MX8QXP, LCDIF video module + gpu/drm/mxsfb driver,
>   adv712x VGA DAC + dumb-vga-dac driver, VGA-connector w/o DDC;
> * try to use drivers chain mxsfb-drm + dumb-vga-dac;
> * any DRM applications consider the monitor is not connected:
>   ===========
>   $ weston-start
>   $ cat /var/log/weston.log
>       ...
>       DRM: head 'VGA-1' found, connector 32 is disconnected.
>       ...
>   $ cat /sys/devices/platform/5a180000.lcdif/drm/card0/card0-VGA-1/status
>   unknown

And that's exactly what's being reported here: we cannot decide if it
is connected or not, so it's unknown.

If weston chooses to ignore connectors that are in an unknown state,
I'd say it's weston's problem, since it's much broader than this
particular device.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com