lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Jul 2019 15:18:57 -0700 From: Joe Perches <joe@...ches.com> To: Saeed Mahameed <saeedm@...lanox.com>, "tanhuazhong@...wei.com" <tanhuazhong@...wei.com>, "davem@...emloft.net" <davem@...emloft.net> Cc: "lipeng321@...wei.com" <lipeng321@...wei.com>, "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>, "salil.mehta@...wei.com" <salil.mehta@...wei.com>, "linuxarm@...wei.com" <linuxarm@...wei.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "liuyonglong@...wei.com" <liuyonglong@...wei.com> Subject: Re: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause On Fri, 2019-07-26 at 22:00 +0000, Saeed Mahameed wrote: > On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote: > > From: Yonglong Liu <liuyonglong@...wei.com> > > > > Some times just see the eth interface have been down/up via > > dmesg, but can not know why the eth down. So adds some debug > > messages to identify the cause for this. [] > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > [] > > @@ -459,6 +459,10 @@ static int hns3_nic_net_open(struct net_device > > *netdev) > > h->ae_algo->ops->set_timer_task(priv->ae_handle, true); > > > > hns3_config_xps(priv); > > + > > + if (netif_msg_drv(h)) > > + netdev_info(netdev, "net open\n"); > > + > > to make sure this is only intended for debug, and to avoid repetition. > #define hns3_dbg(__dev, format, args...) \ > ({ \ > if (netif_msg_drv(h)) \ > netdev_info(h->netdev, format, ##args); \ > }) netif_dbg(h, drv, h->netdev, "net open\n")
Powered by blists - more mailing lists