linux-kernel - Re: [PATCH v3 10/13] objtool: Make recordmcount into an objtool subcmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190728174859.v767keld5x3zylq7@treble>
Date:   Sun, 28 Jul 2019 12:48:59 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Matt Helsley <mhelsley@...are.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v3 10/13] objtool: Make recordmcount into an objtool
 subcmd

On Wed, Jul 24, 2019 at 02:05:04PM -0700, Matt Helsley wrote:
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 08b70ee9614a..43707491317c 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -170,22 +170,21 @@ endif
>  
>  ifdef CONFIG_FTRACE_MCOUNT_RECORD
>  ifndef CC_USING_RECORD_MCOUNT
> -# compiler will not generate __mcount_loc use recordmcount or recordmcount.pl
> -ifdef BUILD_C_RECORDMCOUNT
> +# compiler will not generate __mcount_loc use objtool mcount record or recordmcount.pl

This comment could use some English-ification, something like:

# The compiler doesn't support generation of the __mcount_loc section.
# Generate it manually with "objtool mcount record" or recordmcount.pl.

> @@ -236,9 +235,10 @@ endif # SKIP_STACK_VALIDATION
>  endif # CONFIG_STACK_VALIDATION
>  
>  # Rebuild all objects when objtool changes, or is enabled/disabled.
> -objtool_dep = $(objtool_obj)					\
> +objtool_dep += $(objtool_obj)					\
>  	      $(wildcard include/config/orc/unwinder.h		\
> -			 include/config/stack/validation.h)
> +			 include/config/stack/validation.h	\
> +			 include/config/ftrace/mcount/record.h)

I think the '+=' isn't needed as this is the only place objtool_dep gets
set?

-- 
Josh