linux-kernel - Re: [PATCH v3 00/13] Cleanup recordmcount and begin objtool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190728175258.nsaudvo26xbjmi2y@treble>
Date:   Sun, 28 Jul 2019 12:52:58 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Matt Helsley <mhelsley@...are.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v3 00/13] Cleanup recordmcount and begin objtool
 conversion

On Wed, Jul 24, 2019 at 02:04:54PM -0700, Matt Helsley wrote:
> This series cleans up recordmcount and then makes it into
> an objtool subcommand.
> 
> The series starts with 8 cleanup patches which make recordmcount
> easier to review and integrate with objtool. The final 5 patches
> show the beginning steps of converting recordmcount to use objtool's
> ELF code rather than its own open-coded methods of accessing ELF
> files.
> 
> ---
> 
> v3:
> 	Rebased on mainline. s/elf_open/elf_read/ in recordmcount.c

So this will be the first time objtool will be used on non-x86 arches.
Have you tested the other HAVE_C_RECORDMCOUNT arches, both native and
cross compilation?

Other than my few minor comments, it looks good.  The patches are nicely
split up.  I'll try to be more prompt next time ;-)

-- 
Josh