linux-kernel - Re: [PATCH v3 1/1] sgi-gru: Remove *pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729064842.GA3853@lst.de>
Date:   Mon, 29 Jul 2019 08:48:42 +0200
From:   Christoph Hellwig <hch@....de>
To:     Bharath Vedartham <linux.bhar@...il.com>
Cc:     sivanich@....com, arnd@...db.de, ira.weiny@...el.com,
        jhubbard@...dia.com, jglisse@...hat.com,
        gregkh@...uxfoundation.org, william.kucharski@...cle.com,
        hch@....de, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 1/1] sgi-gru: Remove *pte_lookup functions

On Sat, Jul 27, 2019 at 01:12:00AM +0530, Bharath Vedartham wrote:
> +		ret = get_user_pages_fast(vaddr, 1, write, &page);

I think you want to pass "write ? FOLL_WRITE : 0" here, as
get_user_pages_fast takes a gup_flags argument, not a boolean
write flag.