[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190730102613.GB6825@bharath12345-Inspiron-5559>
Date: Tue, 30 Jul 2019 15:56:13 +0530
From: Bharath Vedartham <linux.bhar@...il.com>
To: Christoph Hellwig <hch@....de>
Cc: sivanich@....com, arnd@...db.de, ira.weiny@...el.com,
jhubbard@...dia.com, jglisse@...hat.com,
gregkh@...uxfoundation.org, william.kucharski@...cle.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 1/1] sgi-gru: Remove *pte_lookup functions
On Mon, Jul 29, 2019 at 08:48:42AM +0200, Christoph Hellwig wrote:
> On Sat, Jul 27, 2019 at 01:12:00AM +0530, Bharath Vedartham wrote:
> > + ret = get_user_pages_fast(vaddr, 1, write, &page);
>
> I think you want to pass "write ? FOLL_WRITE : 0" here, as
> get_user_pages_fast takes a gup_flags argument, not a boolean
> write flag.
You are right there! I ll send another version correcting this.
Thank you
Bharath
Powered by blists - more mailing lists