linux-kernel - Re: [PATCH v2] libata: zpodd: Fix small read overflow in zpodd_get_mech

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c270cac-e946-bba8-03e7-633a7c9006e6@kernel.dk>
Date:   Mon, 29 Jul 2019 16:00:08 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Jeffrin Jose T <jeffrin@...agiritech.edu.in>,
        LKML <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        tobin@...nel.org, Dmitry Vyukov <dvyukov@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v2] libata: zpodd: Fix small read overflow in
 zpodd_get_mech_type()

On 7/29/19 3:58 PM, Nick Desaulniers wrote:
> On Mon, Jul 29, 2019 at 2:55 PM Jens Axboe <axboe@...nel.dk> wrote:
>>
>> On 7/29/19 3:47 PM, Kees Cook wrote:
>>> Jeffrin reported a KASAN issue:
>>>
>>>     BUG: KASAN: global-out-of-bounds in ata_exec_internal_sg+0x50f/0xc70
>>>     Read of size 16 at addr ffffffff91f41f80 by task scsi_eh_1/149
>>>     ...
>>>     The buggy address belongs to the variable:
>>>       cdb.48319+0x0/0x40
>>>
>>> Much like commit 18c9a99bce2a ("libata: zpodd: small read overflow in
>>> eject_tray()"), this fixes a cdb[] buffer length, this time in
>>> zpodd_get_mech_type():
>>>
>>> We read from the cdb[] buffer in ata_exec_internal_sg(). It has to be
>>> ATAPI_CDB_LEN (16) bytes long, but this buffer is only 12 bytes.
>>
>> Applied, thanks.
> 
> Dropped my reviewed by tag. :(
> https://lkml.org/lkml/2019/7/22/865

I'll add it.

-- 
Jens Axboe