linux-kernel - Re: [PATCH 2/2] clk: meson: axg-audio: add g12a reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 15:29:43 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>
Cc:     Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: meson: axg-audio: add g12a reset support

Quoting Jerome Brunet (2019-07-03 05:26:14)
> @@ -1005,8 +1087,27 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
>                 }
>         }
>  
> -       return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
> -                                          data->hw_onecell_data);
> +       ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
> +                                       data->hw_onecell_data);
> +       if (ret)
> +               return ret;
> +
> +       /* Stop here if there is no reset */
> +       if (!data->reset_num)
> +               return 0;
> +
> +       rst = devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL);
> +       if (!rst)
> +               return -ENOMEM;
> +
> +       rst->map = map;
> +       rst->offset = data->reset_offset;
> +       rst->rstc.nr_resets = data->reset_num;
> +       rst->rstc.ops = &axg_audio_rstc_ops;
> +       rst->rstc.of_node = dev->of_node;
> +       rst->rstc.owner = THIS_MODULE;
> +
> +       return ret = devm_reset_controller_register(dev, &rst->rstc);

IS this a typo? Just return devm instead?

>  }
>  
>  static const struct audioclk_data axg_audioclk_data = {