linux-kernel - Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729110727.GB31398@hirez.programming.kicks-ass.net>
Date:   Mon, 29 Jul 2019 13:07:27 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mukesh Ojha <mojha@...eaurora.org>
Cc:     mingo@...hat.com, will@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard
 code value

On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote:
> Let's use the mutex flag macro(which got moved from mutex.c
> to linux/mutex.h in the last patch) instead of hard code
> value which was used in __mutex_owner().
> 
> Signed-off-by: Mukesh Ojha <mojha@...eaurora.org>
> ---
>  include/linux/mutex.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mutex.h b/include/linux/mutex.h
> index 79b28be..c3833ba 100644
> --- a/include/linux/mutex.h
> +++ b/include/linux/mutex.h
> @@ -87,7 +87,7 @@ struct mutex {
>   */
>  static inline struct task_struct *__mutex_owner(struct mutex *lock)
>  {
> -	return (struct task_struct *)(atomic_long_read(&lock->owner) & ~0x07);
> +	return (struct task_struct *)(atomic_long_read(&lock->owner) & ~MUTEX_FLAGS);
>  }

I would _much_ rather move __mutex_owner() out of line, you're exposing
far too much stuff.