[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190729140438.GA2372@penguin>
Date: Mon, 29 Jul 2019 16:04:38 +0200
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: ronald@...ovation.ch, nikolas@....org,
linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: applespi - Fix build error
On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote:
> If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m
> building fails:
>
> drivers/input/keyboard/applespi.o: In function `applespi_probe':
> applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext'
>
> Wrap it in LEDS_CLASS macro to fix this.
No, we should add "depends on LEDS_CLASS" to the Konfig instead.
Thanks.
--
Dmitry
Powered by blists - more mailing lists