linux-kernel - Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d26a4582fad27d0f475cf8bca4d3e6c49987d37d.camel@wdc.com>
Date:   Mon, 29 Jul 2019 18:02:00 +0000
From:   Atish Patra <Atish.Patra@....com>
To:     "schwab@...e.de" <schwab@...e.de>, Anup Patel <Anup.Patel@....com>
CC:     "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "hch@...radead.org" <hch@...radead.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        Alistair Francis <Alistair.Francis@....com>,
        Damien Le Moal <Damien.LeMoal@....com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "anup@...infault.org" <anup@...infault.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "palmer@...ive.com" <palmer@...ive.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>
Subject: Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality

On Mon, 2019-07-29 at 16:40 +0200, Andreas Schwab wrote:
> On Jul 29 2019, Anup Patel <Anup.Patel@....com> wrote:
> 
> > From: Atish Patra <atish.patra@....com>
> > 
> > The RISC-V hypervisor specification doesn't have any virtual timer
> > feature.
> > 
> > Due to this, the guest VCPU timer will be programmed via SBI calls.
> > The host will use a separate hrtimer event for each guest VCPU to
> > provide timer functionality. We inject a virtual timer interrupt to
> > the guest VCPU whenever the guest VCPU hrtimer event expires.
> > 
> > The following features are not supported yet and will be added in
> > future:
> > 1. A time offset to adjust guest time from host time
> > 2. A saved next event in guest vcpu for vm migration
> 
> I'm getting this error:
> 
> In file included from <command-line>:
> ./include/clocksource/timer-riscv.h:12:30: error: unknown type name
> ‘u32’
>    12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
>       |                              ^~~
> ./include/clocksource/timer-riscv.h:12:41: error: unknown type name
> ‘u32’
>    12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
>       |                                         ^~~
> make[1]: *** [scripts/Makefile.build:301: include/clocksource/timer-
> riscv.h.s] Error 1
> 
> Andreas.
> 

Strange. We never saw this error. But I think we should add this one to
the header file (include/clocksource/timer-riscv.h) 

#include <linux/types.h>

Can you try it at your end and confirm please ?

Regards,
Atish