[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20190729.111239.1804738626565032234.davem@davemloft.net>
Date: Mon, 29 Jul 2019 11:12:39 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: gustavo@...eddedor.com
Cc: dougmill@...ux.ibm.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
keescook@...omium.org
Subject: Re: [PATCH] net: ehea: Mark expected switch fall-through
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Sun, 28 Jul 2019 19:30:09 -0500
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_mem_notifier':
> include/linux/printk.h:311:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/ibm/ehea/ehea_main.c:3253:3: note: in expansion of macro 'pr_info'
> pr_info("memory offlining canceled");
> ^~~~~~~
> drivers/net/ethernet/ibm/ehea/ehea_main.c:3256:2: note: here
> case MEM_ONLINE:
> ^~~~
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Applied.
Powered by blists - more mailing lists