linux-kernel - RE: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d3e0b8ba1444194a153c93faa1cabb3@AUSX13MPC105.AMER.DELL.COM>
Date:   Tue, 30 Jul 2019 21:05:22 +0000
From:   <Mario.Limonciello@...l.com>
To:     <kbusch@...nel.org>, <kai.heng.feng@...onical.com>
CC:     <rjw@...ysocki.net>, <keith.busch@...el.com>, <hch@....de>,
        <sagi@...mberg.me>, <linux-nvme@...ts.infradead.org>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rajatja@...gle.com>
Subject: RE: [Regression] Commit "nvme/pci: Use host managed power state for
 suspend" has problems

> -----Original Message-----
> From: Keith Busch <kbusch@...nel.org>
> Sent: Tuesday, July 30, 2019 2:20 PM
> To: Kai-Heng Feng
> Cc: Limonciello, Mario; rjw@...ysocki.net; keith.busch@...el.com; hch@....de;
> sagi@...mberg.me; linux-nvme@...ts.infradead.org; linux-pm@...r.kernel.org;
> linux-kernel@...r.kernel.org; rajatja@...gle.com
> Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> suspend" has problems
> 
> 
> [EXTERNAL EMAIL]
> 
> On Wed, Jul 31, 2019 at 02:50:01AM +0800, Kai-Heng Feng wrote:
> >
> > Just did a quick test, this patch regress SK Hynix BC501, the SoC stays at
> > PC3 once the patch is applied.
> 
> Okay, I'm afraid device/platform quirks may be required unless there are
> any other ideas out there.

I think if a quirk goes in for Rafael's SSD it would have to be a quirk specific to this
device and FW version per the findings on KH checking the same device with the
older FW version.

> 
> I'm not a big fan of adding more params to this driver. Those are
> global to the module, so that couldn't really handle a platform with
> two different devices that want different behavior.