linux-kernel - Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190730213114.GK13948@localhost.localdomain>
Date:   Tue, 30 Jul 2019 15:31:14 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Mario.Limonciello@...l.com
Cc:     kai.heng.feng@...onical.com, rjw@...ysocki.net,
        keith.busch@...el.com, hch@....de, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, rajatja@...gle.com
Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
 suspend" has problems

On Tue, Jul 30, 2019 at 09:05:22PM +0000, Mario.Limonciello@...l.com wrote:
> > -----Original Message-----
> > From: Keith Busch <kbusch@...nel.org>
> > Sent: Tuesday, July 30, 2019 2:20 PM
> > To: Kai-Heng Feng
> > Cc: Limonciello, Mario; rjw@...ysocki.net; keith.busch@...el.com; hch@....de;
> > sagi@...mberg.me; linux-nvme@...ts.infradead.org; linux-pm@...r.kernel.org;
> > linux-kernel@...r.kernel.org; rajatja@...gle.com
> > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for
> > suspend" has problems
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > On Wed, Jul 31, 2019 at 02:50:01AM +0800, Kai-Heng Feng wrote:
> > >
> > > Just did a quick test, this patch regress SK Hynix BC501, the SoC stays at
> > > PC3 once the patch is applied.
> > 
> > Okay, I'm afraid device/platform quirks may be required unless there are
> > any other ideas out there.
> 
> I think if a quirk goes in for Rafael's SSD it would have to be a quirk specific to this
> device and FW version per the findings on KH checking the same device with the
> older FW version.

That's fine, we have the infrastructure in place for fw specific quirks.
See drivers/nvme/host/core.c:nvme_core_quirk_entry