linux-kernel - Re: [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hef28nfcm.wl-tiwai@suse.de>
Date:   Tue, 30 Jul 2019 09:36:41 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     " Gustavo A. R. Silva " <gustavo@...eddedor.com>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Kees Cook" <keescook@...omium.org>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through

On Mon, 29 Jul 2019 22:54:54 +0200,
 Gustavo A. R. Silva  wrote:
> 
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: m68k):
> 
> sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]:  => 1449:24
> 
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> Changes in v2:
>  - Update code so switch and case statements are at the same indent.

Applied, thanks.


Takashi