linux-kernel - Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hd0hsnf8p.wl-tiwai@suse.de>
Date:   Tue, 30 Jul 2019 09:39:02 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     " Gustavo A. R. Silva " <gustavo@...eddedor.com>
Cc:     "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Kees Cook" <keescook@...omium.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs

On Tue, 30 Jul 2019 03:49:44 +0200,
 Gustavo A. R. Silva  wrote:
> 
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warnings (Building: sparc64):
> 
> sound/sparc/dbri.c: In function ‘reverse_bytes’:
> sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
>    ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:583:2: note: here
>   case 16:
>   ^~~~
> sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8);
>    ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:585:2: note: here
>   case 8:
>   ^~~~
> sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4);
>    ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:587:2: note: here
>   case 4:
>   ^~~~
> sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2);
>    ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/sparc/dbri.c:589:2: note: here
>   case 2:
>   ^~~~
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied, thanks.


Takashi